feat(tracing-appender): add support for rolling file using local time feature #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-online
force-pushed
the
feat/tracing-appender-local-time
branch
from
b0689e9 to
c10ced4
Compare
… feature Co-authored-by: messense <[email protected]>
dan-online
force-pushed
the
feat/tracing-appender-local-time
branch
from
17e15f1 to
07e8e7a
Compare
|
I'd really like to use this, what's up with this PR? |
I want to know too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3102 and based on #3105 which seems to have stalled
Solution
Add a local-time feature to tracing-appender (just like the one in tracing-subscriber) to modify the behavior.